chore: migrate remaining gulp build tasks to nx by chaosmirage · Pull Request #33510 · DevExpress/DevExtreme

chaosmirage · 2026-05-06T09:42:36Z

This PR should be merged to the 26_1 branch after #33434

…ia nx target

…expression

… behaviour

…eol behavior

…ssembly

…:meta targets

…Express/DevExtreme into chore/migrate-devextreme-to-nx-part-9 # Conflicts: # packages/devextreme/build/gulp/npm.js # packages/devextreme/gulpfile.js # packages/devextreme/project.json # packages/nx-infra-plugin/src/executors/bundle/executor.e2e.spec.ts # packages/nx-infra-plugin/src/executors/bundle/executor.ts # packages/nx-infra-plugin/src/executors/bundle/schema.json # packages/nx-infra-plugin/src/executors/bundle/schema.ts # packages/nx-infra-plugin/src/executors/compress/executor.ts # packages/nx-infra-plugin/src/executors/compress/schema.json # packages/nx-infra-plugin/src/executors/compress/schema.ts # packages/nx-infra-plugin/src/executors/concatenate-files/executor.ts # packages/nx-infra-plugin/src/executors/copy-files/executor.ts # packages/nx-infra-plugin/src/utils/file-operations.ts # pnpm-lock.yaml

Copilot

Pull request overview

This PR continues the DevExtreme build-pipeline migration by moving remaining Gulp-based build tasks into devextreme-nx-infra-plugin Nx executors (with the repo’s “thin executor.ts + <name>.impl.ts” pattern), and wiring DevExtreme’s gulpfile.js to invoke Nx targets for npm packaging, license notice checks, and state-manager optimization.

Changes:

Introduces new Nx executors (e.g., dts-modules, dts-bundle, scss-assemble, license-check, state-manager-optimize, npm-assemble) and shared utilities (createExecutor, glob discovery, license banner rendering).
Refactors multiple existing executors to the executor.ts re-export + *.impl.ts implementation pattern, and expands executor schemas (incl. license-header options).
Updates packages/devextreme/gulpfile.js to call Nx targets and removes legacy Gulp state-manager and license-check tasks; adds npm template files previously produced by Gulp.

Reviewed changes

Copilot reviewed 132 out of 142 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/nx-infra-plugin/src/utils/types.ts	Adds `PackageJson` type for license/banner utilities.
packages/nx-infra-plugin/src/utils/path-resolver.ts	Adds `toPosixPath` and `resolveOptionPaths` helpers.
packages/nx-infra-plugin/src/utils/license-banner.ts	Adds reusable license banner templating helpers.
packages/nx-infra-plugin/src/utils/license-banner.e2e.spec.ts	E2E tests for license banner rendering/extraction.
packages/nx-infra-plugin/src/utils/index.ts	Exports additional utils (`create-executor`, `glob-discovery`).
packages/nx-infra-plugin/src/utils/glob-discovery.ts	Adds glob expansion/discovery helpers.
packages/nx-infra-plugin/src/utils/file-operations.ts	Adds `loadProjectPackageJson` helper.
packages/nx-infra-plugin/src/utils/create-executor.ts	Adds `createExecutor` wrapper for consistent executor runtime/error handling.
packages/nx-infra-plugin/src/executors/vectormap/schema.ts	Adds `applyLicenseHeaders` option typing for vectormap.
packages/nx-infra-plugin/src/executors/vectormap/schema.json	Documents/extends vectormap executor schema.
packages/nx-infra-plugin/src/executors/vectormap/executor.ts	Switches to re-exporting `vectormap.impl`.
packages/nx-infra-plugin/src/executors/vectormap/executor.e2e.spec.ts	Adds wiring test for license-header forwarding.
packages/nx-infra-plugin/src/executors/state-manager-optimize/state-manager-optimize.impl.ts	New executor to rewrite/remove dev-only `state_manager` modules.
packages/nx-infra-plugin/src/executors/state-manager-optimize/schema.ts	Schema typings for state-manager optimization.
packages/nx-infra-plugin/src/executors/state-manager-optimize/schema.json	JSON schema for state-manager optimization.
packages/nx-infra-plugin/src/executors/state-manager-optimize/executor.ts	Re-export entrypoint for state-manager optimization executor.
packages/nx-infra-plugin/src/executors/state-manager-optimize/executor.e2e.spec.ts	E2E coverage for state-manager optimization behavior.
packages/nx-infra-plugin/src/executors/scss-assemble/scss-assemble.impl.ts	New SCSS assemble executor with `data-uri()` inlining + asset copy.
packages/nx-infra-plugin/src/executors/scss-assemble/schema.ts	Schema typings for SCSS assemble executor.
packages/nx-infra-plugin/src/executors/scss-assemble/schema.json	JSON schema for SCSS assemble executor.
packages/nx-infra-plugin/src/executors/scss-assemble/executor.ts	Re-export entrypoint for SCSS assemble executor.
packages/nx-infra-plugin/src/executors/scss-assemble/executor.e2e.spec.ts	E2E coverage for SCSS assemble functionality.
packages/nx-infra-plugin/src/executors/prepare-submodules/schema.json	Tightens/modernizes schema metadata.
packages/nx-infra-plugin/src/executors/prepare-submodules/prepare-submodules.impl.ts	Moves implementation into `*.impl.ts` with `createExecutor`.
packages/nx-infra-plugin/src/executors/prepare-submodules/executor.ts	Switches to re-exporting `prepare-submodules.impl`.
packages/nx-infra-plugin/src/executors/prepare-submodules/executor.e2e.spec.ts	Updates E2E assertions around relative-path correctness.
packages/nx-infra-plugin/src/executors/prepare-package-json/schema.ts	Expands prepare-package-json options typing.
packages/nx-infra-plugin/src/executors/prepare-package-json/schema.json	Adds schema metadata and additional options fields.
packages/nx-infra-plugin/src/executors/prepare-package-json/prepare-package-json.impl.ts	New implementation supporting transforms (remove fields, rename, version source).
packages/nx-infra-plugin/src/executors/prepare-package-json/executor.ts	Switches to re-exporting `prepare-package-json.impl`.
packages/nx-infra-plugin/src/executors/prepare-package-json/executor.e2e.spec.ts	Adds/updates E2E cases for new transformations.
packages/nx-infra-plugin/src/executors/pack-npm/schema.json	Updates schema metadata.
packages/nx-infra-plugin/src/executors/pack-npm/pack-npm.impl.ts	Moves `pnpm pack` logic into `*.impl.ts` via `createExecutor`.
packages/nx-infra-plugin/src/executors/pack-npm/executor.ts	Switches to re-exporting `pack-npm.impl`.
packages/nx-infra-plugin/src/executors/npm-assemble/schema.ts	Adds schema typings for npm assembly pipeline.
packages/nx-infra-plugin/src/executors/npm-assemble/schema.json	Adds JSON schema for npm assembly pipeline.
packages/nx-infra-plugin/src/executors/npm-assemble/executor.ts	Re-export entrypoint for npm-assemble executor.
packages/nx-infra-plugin/src/executors/localization/schema.ts	Adds `applyLicenseHeaders` option typing.
packages/nx-infra-plugin/src/executors/localization/schema.json	Updates schema metadata + adds `applyLicenseHeaders` option.
packages/nx-infra-plugin/src/executors/localization/executor.e2e.spec.ts	Adds E2E wiring test for license-header forwarding.
packages/nx-infra-plugin/src/executors/license-check/schema.ts	Adds typings for license notice verification entries.
packages/nx-infra-plugin/src/executors/license-check/schema.json	Adds JSON schema for license notice verification.
packages/nx-infra-plugin/src/executors/license-check/license-check.impl.ts	Implements license notice verification executor.
packages/nx-infra-plugin/src/executors/license-check/executor.ts	Re-export entrypoint for license-check executor.
packages/nx-infra-plugin/src/executors/license-check/executor.e2e.spec.ts	E2E coverage for license-check executor behavior.
packages/nx-infra-plugin/src/executors/karma-multi-env/schema.json	Updates schema metadata/URL and descriptions.
packages/nx-infra-plugin/src/executors/generate-components/schema.json	Updates schema metadata/URL and descriptions.
packages/nx-infra-plugin/src/executors/generate-component-names/schema.json	Updates schema metadata/URL and descriptions.
packages/nx-infra-plugin/src/executors/generate-component-names/generate-component-names.impl.ts	Moves implementation into `*.impl.ts` via `createExecutor`.
packages/nx-infra-plugin/src/executors/generate-component-names/executor.ts	Switches to re-exporting `generate-component-names.impl`.
packages/nx-infra-plugin/src/executors/dts-modules/schema.ts	Adds typings for dts-modules executor options.
packages/nx-infra-plugin/src/executors/dts-modules/schema.json	Adds JSON schema for dts-modules executor.
packages/nx-infra-plugin/src/executors/dts-modules/executor.ts	Re-export entrypoint for dts-modules executor.
packages/nx-infra-plugin/src/executors/dts-modules/executor.e2e.spec.ts	E2E coverage for dts-modules pipeline outputs.
packages/nx-infra-plugin/src/executors/dts-modules/dts-modules.impl.ts	Implements `.d.ts` assembly + licensing + debug stripping.
packages/nx-infra-plugin/src/executors/dts-bundle/schema.ts	Adds typings for dts-bundle executor options.
packages/nx-infra-plugin/src/executors/dts-bundle/schema.json	Adds JSON schema for dts-bundle executor.
packages/nx-infra-plugin/src/executors/dts-bundle/executor.ts	Re-export entrypoint for dts-bundle executor.
packages/nx-infra-plugin/src/executors/dts-bundle/executor.e2e.spec.ts	E2E coverage for dts-bundle outputs/transforms.
packages/nx-infra-plugin/src/executors/dts-bundle/dts-bundle.impl.ts	Implements TS declaration bundle concatenation + transforms + banners.
packages/nx-infra-plugin/src/executors/create-dual-mode-manifest/schema.json	Updates schema metadata/URL and required fields formatting.
packages/nx-infra-plugin/src/executors/copy-files/schema.ts	Adds excludePatterns per entry + license-header piping option type export.
packages/nx-infra-plugin/src/executors/copy-files/schema.json	Updates schema metadata + adds new options docs.
packages/nx-infra-plugin/src/executors/copy-files/executor.ts	Switches to re-exporting `copy-files.impl` + exports helper.
packages/nx-infra-plugin/src/executors/copy-files/executor.e2e.spec.ts	Adds E2E coverage for excludePatterns and license piping.
packages/nx-infra-plugin/src/executors/copy-files/copy-files.impl.ts	New implementation with glob excludes + optional post license stamping.
packages/nx-infra-plugin/src/executors/concatenate-files/schema.json	Updates schema metadata/description.
packages/nx-infra-plugin/src/executors/concatenate-files/executor.ts	Switches to re-exporting impl + exports concat helpers.
packages/nx-infra-plugin/src/executors/concatenate-files/concatenate-files.impl.ts	New implementation module with reusable concat helpers.
packages/nx-infra-plugin/src/executors/compress/schema.ts	Adds optional license-header application option.
packages/nx-infra-plugin/src/executors/compress/schema.json	Updates schema metadata + documents license-header option.
packages/nx-infra-plugin/src/executors/compress/executor.ts	Switches to re-exporting impl + exports `stripDebug`.
packages/nx-infra-plugin/src/executors/compress/executor.e2e.spec.ts	Expands E2E coverage (strip-debug mode, excludes, glob expansion, etc.).
packages/nx-infra-plugin/src/executors/clean/schema.json	Updates schema metadata/description.
packages/nx-infra-plugin/src/executors/clean/executor.ts	Switches to re-exporting impl + exports helper functions.
packages/nx-infra-plugin/src/executors/clean/clean.impl.ts	New implementation module with reusable deletion helpers.
packages/nx-infra-plugin/src/executors/bundle/schema.ts	Adds applyLicenseHeaders option typing.
packages/nx-infra-plugin/src/executors/bundle/schema.json	Updates schema metadata + documents applyLicenseHeaders option.
packages/nx-infra-plugin/src/executors/bundle/executor.ts	Switches to re-exporting `bundle.impl`.
packages/nx-infra-plugin/src/executors/bundle/executor.e2e.spec.ts	Adds E2E wiring test for license-header forwarding.
packages/nx-infra-plugin/src/executors/build-typescript/schema.json	Updates schema metadata/URL and enum formatting.
packages/nx-infra-plugin/src/executors/build-angular-library/schema.json	Updates schema metadata/URL and required formatting.
packages/nx-infra-plugin/src/executors/build-angular-library/executor.ts	Switches to re-exporting `build-angular-library.impl`.
packages/nx-infra-plugin/src/executors/babel-transform/schema.ts	Adds `copyAssets` option typing.
packages/nx-infra-plugin/src/executors/babel-transform/schema.json	Updates schema metadata + documents `copyAssets`.
packages/nx-infra-plugin/src/executors/babel-transform/executor.ts	Switches to re-exporting `babel-transform.impl`.
packages/nx-infra-plugin/src/executors/babel-transform/executor.e2e.spec.ts	Adds E2E coverage for `copyAssets` and removeDebug wiring.
packages/nx-infra-plugin/src/executors/babel-transform/babel-transform.impl.ts	New implementation with asset copying and shared stripDebug helper.
packages/nx-infra-plugin/src/executors/add-license-headers/schema.ts	Adds new shared `ApplyLicenseHeadersOption` and adds mode/commentType to main schema.
packages/nx-infra-plugin/src/executors/add-license-headers/schema.json	Updates schema metadata + adds mode/commentType definitions.
packages/nx-infra-plugin/src/executors/add-license-headers/license-header-mit.txt	Adds bundled MIT license header template.
packages/nx-infra-plugin/src/executors/add-license-headers/license-header-eula.txt	Adds bundled EULA license header template.
packages/nx-infra-plugin/src/executors/add-license-headers/defaults.ts	Adds defaults + template resolver for license stamping.
packages/nx-infra-plugin/src/executors/add-license-headers/add-license-headers.impl.ts	New implementation with reusable banner/header application helpers.
packages/nx-infra-plugin/scripts/build.ts	Copies `.txt` assets; updates build script logging + asset copying behavior.
packages/nx-infra-plugin/executors.json	Registers new executors in the plugin catalog.
packages/nx-infra-plugin/CLAUDE.md	Adds agent tooling pointer doc.
packages/nx-infra-plugin/AGENTS.md	Adds contributor guidance and executor conventions for the plugin.
packages/devextreme/gulpfile.js	Replaces several gulp tasks with Nx invocations; adds `npm` configuration logic.
packages/devextreme/build/npm-templates/integration/jquery.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/events/transform.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/events/swipe.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/events/pointer.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/events/hover.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/events/hold.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/events/drag.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/events/dblclick.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/events/contextmenu.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/events/click.d.ts	Adds npm template file previously generated via Gulp.
packages/devextreme/build/npm-templates/bundles/dx.all.js	Adds Angular “dx.all.js” hack file template.
packages/devextreme/build/npm-templates/.npmignore	Adds `.npmignore` template for assembled package.
packages/devextreme/build/gulp/state_manager/replace_state_manager_modules_for_production.js	Removes legacy Gulp state-manager module rewrite task.
packages/devextreme/build/gulp/state_manager/remove_development_state_manager_modules.js	Removes legacy Gulp state-manager dev module removal task.
packages/devextreme/build/gulp/state_manager/index.js	Removes legacy Gulp state-manager task wiring.
packages/devextreme/build/gulp/state_manager/constants.js	Removes legacy Gulp state-manager constants.
packages/devextreme/build/gulp/state_manager/tests/build_state_manager.test.js	Removes legacy Gulp state-manager tests.
packages/devextreme/build/gulp/header-pipes.js	Fixes license header template path join.
packages/devextreme/build/gulp/check_licenses.js	Removes legacy Gulp license notice check task.
packages/devextreme-vue/project.json	Switches add-license-headers executor to MIT mode.
packages/devextreme-react/project.json	Switches add-license-headers executor to MIT mode.
packages/devextreme-angular/project.json	Switches add-license-headers executor to MIT mode.

+export function resolveOptionPaths<T extends Record<string, unknown>, K extends keyof T>(
+  options: T,
+  projectRoot: string,
+  keys: readonly K[],
+  defaults?: Partial<Record<K, string>>,
+): Record<K, string> {
+  const out = {} as Record<K, string>;
+  for (const key of keys) {
+    const raw = (options[key] as string | undefined) ?? defaults?.[key];
+    if (raw !== undefined) {
+      out[key] = path.resolve(projectRoot, raw);
+    }
+  }
+  return out;


+export function buildLicenseRegex(entry: LicenseEntry): RegExp {
+  const pattern =
+    `\\* !\\s*.*${entry.name}${LICENSE_FIELD_SEPARATOR}`
+    + `${entry.homepageUrl}${LICENSE_FIELD_SEPARATOR}*\\*\\s`
+    + `${entry.copyright}${LICENSE_FIELD_SEPARATOR}`
+    + `${entry.licenseType}${LICENSE_FIELD_SEPARATOR}`
+    + `${entry.licenseUrl}`;
+  return new RegExp(pattern);
+}


+/*!
+ * <%= pkg.name %>
+ * Version: <%= pkg.version %>
+ * Build date: <%= date %>


chaosmirage added the force all tests label May 6, 2026

github-actions Bot added the .d.ts label May 6, 2026

chaosmirage force-pushed the chore/migrate-devextreme-to-nx-part-9 branch 7 times, most recently from 33f6961 to 248a9dc Compare May 6, 2026 13:39

chaosmirage added 13 commits May 6, 2026 16:50

chore(nx-infra-plugin): extract containsGlobPattern to shared utils

16d9d35

chore(devextreme): migrate build:aspnet to nx executor

faa9922

chore(devextreme): migrate copy:vendor to nx executors

02aacf2

chore(devextreme): migrate bundle:prod compression to nx executors

10854ab

chore(devextreme): migrate bundle:debug compression to nx executors

c77335e

feat(nx-infra-plugin): add exclude API to compress executor

8e0a10a

chore(devextreme): replace compressionPipes.beautify in npm-sources v…

b5434d9

…ia nx target

chore(devextreme): replace comporessPipes in transpile.js via inline …

a1b0db8

…expression

chore(devextreme): remove compression-pipes.js

d559c4f

chore(nx-infra-plugin): compress executor, align modes with gulp task…

81bb142

… behaviour

chore(devextreme): run copy:vendor sub-targets in parallel

d343603

chore: bump nx from 22.4.5 to 22.7.0

5091897

fix(nx-infra-plugin): normalize line endings to os.EOL to match gulp-…

86f9a4c

…eol behavior

chaosmirage self-assigned this May 6, 2026

chaosmirage changed the base branch from 26_1 to chore/migrate-devextreme-to-nx-part-8 May 6, 2026 13:52

chaosmirage added 6 commits May 6, 2026 17:02

feat(nx-infra-plugin): extend executors for npm-assembly migration

99239ba

feat(nx-infra-plugin): dts-modules and dts-bundle executors for npm-a…

56da2b6

…ssembly

chore(devextreme): add build:npm:dist:package-json and build:npm:dist…

f0c6682

…:meta targets

feat(nx-infra-plugin): implement npm-assemble executor

6182c57

feat(nx-infra-plugin): implement scss-assemble executor

7f6afb4

chore(devextreme): add build:npm composite and dist-flatten target

52ee7c9

chaosmirage requested a review from a team as a code owner May 7, 2026 17:48

Base automatically changed from chore/migrate-devextreme-to-nx-part-8 to 26_1 May 12, 2026 15:31

GoodDayForSurf and others added 3 commits May 14, 2026 00:26

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

60f628f

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

0aa660d

GoodDayForSurf closed this May 14, 2026

GoodDayForSurf reopened this May 14, 2026

GoodDayForSurf added 2 commits May 14, 2026 17:30

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

f4835aa

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

6f7ddba

GoodDayForSurf closed this May 14, 2026

GoodDayForSurf reopened this May 14, 2026

GoodDayForSurf added 2 commits May 14, 2026 22:56

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

892e36b

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

34f8630

GoodDayForSurf closed this May 15, 2026

GoodDayForSurf reopened this May 15, 2026

GoodDayForSurf added 10 commits May 15, 2026 12:05

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

97b9dda

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

1bad8e1

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

9294cea

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

be049c4

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

c1d93f3

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

3da377d

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

8a1ea32

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

db3eec9

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

b2b5004

Merge branch '26_1' into chore/migrate-devextreme-to-nx-part-9

5cf071e

GoodDayForSurf closed this May 18, 2026

GoodDayForSurf reopened this May 18, 2026

alexslavr requested a review from Copilot May 19, 2026 13:04

Copilot started reviewing on behalf of alexslavr May 19, 2026 13:04 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate remaining gulp build tasks to nx#33510

chore: migrate remaining gulp build tasks to nx#33510
chaosmirage wants to merge 57 commits into
26_1from
chore/migrate-devextreme-to-nx-part-9

chaosmirage commented May 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chaosmirage commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chaosmirage commented May 6, 2026 •

edited

Loading